Skip to content

Comments

Update some AndroidX libraries#6719

Merged
Redirion merged 1 commit intoTeamNewPipe:devfrom
TacoTheDank:core-lifecycle-bump
Aug 1, 2021
Merged

Update some AndroidX libraries#6719
Redirion merged 1 commit intoTeamNewPipe:devfrom
TacoTheDank:core-lifecycle-bump

Conversation

@TacoTheDank
Copy link
Member

@TacoTheDank TacoTheDank commented Jul 20, 2021 •
edited
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This PR is meant as a follow up to #6702.

  • Use NotificationChannelCompat. #6633 (comment)
  • Update AndroidX AppCompat 1.3.0 -> 1.3.1 (changelog)
  • Update AndroidX Core 1.3.2 -> 1.6.0 (changelog)
  • Update AndroidX Fragment 1.3.5 -> 1.3.6 (changelog)
  • Update AndroidX Lifecycle 2.2.0 -> 2.3.1 (changelog)
  • Users are basically already using these versions internally because of AppCompat's upgrade to 1.3.0 (other than Core 1.6.0, because AppCompat 1.3.0 uses Core 1.5.0 internally)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

Stypox
Stypox previously approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read the changelogs and could not find anything that could break NewPipe, though I do not know enough about AndroidX libraries.

@Redirion
Copy link
Member

Redirion commented Jul 21, 2021 •
edited
Loading

assuming further appCompat versions will also update it's transitive dependencies to recommended versions, would anything be speaking against removing the dependencies to core and lifecycle completely from the build.gradle?

Would make future updates easier / require less maintenance for the dependencies.

@TacoTheDank
Copy link
Member Author

TacoTheDank commented Jul 21, 2021 •
edited
Loading

assuming further appCompat versions will also update it's transitive dependencies to recommended versions, would anything be speaking against removing the dependencies to core and lifecycle completely from the build.gradle?

Would make future updates easier / require less maintenance for the dependencies.

I would probably recommend keeping them, as they can also be updated separately, and allow for usage of Kotlin extensions as well (core-ktx, lifecycle ktx, etc.).

And sometimes lower transitive versions are used if specific versions are not specified in the dependency block.

@TacoTheDank
Copy link
Member Author

TacoTheDank commented Jul 21, 2021

AndroidX AppCompat 1.3.1 and AndroidX Fragment 1.3.6 came out today, so I'll include those in this PR as they're just bugfix releases.

@TacoTheDank TacoTheDank changed the title Update AndroidX Core and Lifecycle library versions Update some AndroidX libraries Jul 21, 2021
Stypox
Stypox approved these changes Aug 1, 2021
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Redirion merge this if you think it looks fine

@Redirion Redirion merged commit 896aec5 into TeamNewPipe:dev Aug 1, 2021
@TacoTheDank TacoTheDank deleted the core-lifecycle-bump branch August 1, 2021 19:49
This was referenced Aug 4, 2021
Merged
Closed
@TacoTheDank TacoTheDank added the codequality Improvements to the codebase to improve the code quality label Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Stypox Stypox Stypox approved these changes

Assignees

No one assigned

Labels

codequality Improvements to the codebase to improve the code quality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TacoTheDank @Redirion @Stypox